Skip to content

[IMP] Array-1 #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amitmittal117 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] Array-1 #1921

amitmittal117 wants to merge 1 commit into from

Conversation

@amitmittal117
Copy link

@amitmittal117 amitmittal117 commented Nov 25, 2025

No description provided.

@super30admin
Copy link
Owner

super30admin commented Nov 25, 2025

  • Strengths:
    • The student has correctly implemented the solution and provided optimizations.
    • The code is well-commented and easy to understand.
    • The student has considered both time and space complexity and provided an efficient solution.
  • Areas for Improvement:
    • The initial solution could have been directly optimized to use a single array instead of two separate arrays, but the student quickly corrected this in the optimized version.
    • The comments could be more detailed to explain the intuition behind the optimizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amitmittal117 @super30admin